Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting by ratio broken when there's an infinite in the list #316

Closed
jcdm opened this issue Mar 5, 2019 · 6 comments
Closed

Sorting by ratio broken when there's an infinite in the list #316

jcdm opened this issue Mar 5, 2019 · 6 comments
Labels

Comments

@jcdm
Copy link

jcdm commented Mar 5, 2019

Please provide the following information.

  • Transmssion version: 2.95

  • Tr Web Control version: 1.6.0 beta (20180906)

  • Browser name & version:Chrome Version 72.0.3626.119

  • Problem description:
    When sorting by ratio complete, the interface sorts correctly on load, but then on the first (and subsequent) Auto Reloads the sort breaks into two lists both of which are correctly sorted, but with the 'infinite' ratio item (which is also listed as last activity 1970-01-01) between them. It seems one item is throwing off 'null' values and that's breaking the sort.

I don't see any pattern in what's sorted into each of the two lists. Added date, queue and number all seem to be unrelated.

On first load and sort, the 'nulls' are sorted to the end of the list (which I'd consider to be correct) but on the subsequent reloads they appear in the mix of the list, breaking the sorting of the other objects with them.

@jcdm
Copy link
Author

jcdm commented Mar 5, 2019

image

@ronggang
Copy link
Owner

ronggang commented Mar 6, 2019

@jcdm Thanks for feedback.

@jcdm
Copy link
Author

jcdm commented Mar 6, 2019

Gosh - that was fast! I was planning to have a crack at this myself in a few hours. Many thanks! I look forward to receiving it in the next update in due course 👍🏻

@ronggang
Copy link
Owner

ronggang commented Mar 6, 2019

@jcdm You can use the install script to update Webui to an unreleased version.
image

@jcdm
Copy link
Author

jcdm commented Mar 6, 2019

That fix seems to have worked perfectly.

Thank you for that and the tip on installing! 🙏🏻

@ronggang
Copy link
Owner

ronggang commented Mar 7, 2019

You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants