Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

255 rows limit in Excel #48

Closed
bandlor opened this issue Jul 1, 2013 · 1 comment
Closed

255 rows limit in Excel #48

bandlor opened this issue Jul 1, 2013 · 1 comment

Comments

@bandlor
Copy link

bandlor commented Jul 1, 2013

I have repeating issue with loading of XLS files that were generated by some application (I do not have technical details) where exactly first 255 rows are red.
However when I open and save this file in the Excel, all lines all loaded properly.
This must be some race condition or unexpected error in the input file, but since I want to implement automated imports I'd like to resolve the issue.

I can not share the sample excel file (contains company data) but I can try to investigate and maybe provide a fix if some will point me in a good direction.
I will investigate anyway, but any help is appreciated :-)

Regards

@bandlor
Copy link
Author

bandlor commented Jul 1, 2013

Sorry, cancel the alarms, this in not issue of Roo but Spreadsheet library.
For unknown reason the rows are red from the file, but dimensions variable is not calculated
and .each method (using those dimensions) in Worksheet class only return first 255 records to Roo.

As workaround I have forced the dimension calculation in Roo::Excel class by adding line 248 in "read_cells"

=    worksheet = @workbook.worksheet(sheet_no(sheet))
+    worksheet.dimensions
=   row_index=1

But this is not to be fixed in Roo so I will not post any patch for that.
I will try to post proper patch directly to Spreadsheet project later.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant