Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clisops: need to replace identification of dimensions by name #32

Closed
agstephens opened this issue Jul 23, 2020 · 2 comments
Closed

clisops: need to replace identification of dimensions by name #32

agstephens opened this issue Jul 23, 2020 · 2 comments

Comments

@agstephens
Copy link
Collaborator

agstephens commented Jul 23, 2020

Instead of looking for "lat" or "latitude", clisops should use:

is_longitude(dim)
is_latitude(dim)
etc etc

See: https://github.com/roocs/dachar/blob/b2b058615696eae2ef58614c7ba248cfa34ca06d/dachar/utils/character.py#L28

@Zeitsperre
Copy link
Collaborator

I feel like this project might be interested in such a feature as well: https://github.com/xarray-contrib/cf-xarray

@agstephens
Copy link
Collaborator Author

Thanks @Zeitsperre , that looks really interesting! Might simplify things for us.
@ellesmith88 - we should explore whether cf-xarray is a drop-in replacement for our coord variable getters, e.g.: get_longitude()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants