Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan should only calc min and max if mode is "full" #6

Closed
agstephens opened this issue Mar 2, 2020 · 1 comment
Closed

Scan should only calc min and max if mode is "full" #6

agstephens opened this issue Mar 2, 2020 · 1 comment
Assignees
@ellesmith88

Comments

@agstephens
Copy link
Contributor

  • scan should NOT read all the data values by default
    • the default should be "quick" mode
    • It should set the min and max of the main variable to: None
  • add a command-line argument called "-m|--mode" that defaults to "quick"
    • it can be set to "full"
    • if mode is "full": then DO calculate the min and max.
agstephens referenced this issue in roocs/character-scanner-test Mar 9, 2020
@agstephens
Merge pull request #22 from roocs/add_modes
b5a8e6f 
Fix for issues #18 and #19
@agstephens
Copy link
Contributor Author

Done.

@ellesmith88 ellesmith88 transferred this issue from roocs/character-scanner-test Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellesmith88 ellesmith88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agstephens @ellesmith88