Local Kubeconfig for easier development #31
Conversation
|
I don't think TPR support should be removed in favor for 1.10, unless we "announce" it and/or make a tag/branch with TPR and one continuing development without TPR support.. Are you experiencing issues with 1.10 using the operator-kit as is? |
|
Specifically trying to get support for 1.10 |
|
In theory in my projects I could use |
christopherhein
force-pushed
the
feature/1-10-support
branch
from
ad6e62a
to
bf5e326
Compare
christopherhein
changed the title
|
@jbw976 Updated. |
christopherhein
force-pushed
the
feature/1-10-support
branch
2 times, most recently
from
717082e
to
8a3160b
Compare
sample-operator/main.go
Outdated
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to get k8s config. %+v", err) | ||
| } | ||
|
|
||
| clientset, err := kubernetes.NewForConfig(config) | ||
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to get k8s client. %+v", err) | ||
| return nil, nil, fmt.Errorf("failed to get kubernetes client. %+v", err) |
There was a problem hiding this comment.
The other errors generated in this file all have k8s not kubernetes, so it would be good to keep it the same here as it was.
christopherhein
force-pushed
the
feature/1-10-support
branch
from
8a3160b
to
639c610
Compare
|
@galexrt updated 👍 |
**Why:** * makes it so you can pass `-kubeconfig` for a local config **This change addresses the need by:** * closes rook#30 Signed-off-by: Christopher Hein <me@christopherhein.com>
christopherhein
force-pushed
the
feature/1-10-support
branch
from
639c610
to
3459f4c
Compare
|
@christopherhein Thanks for bearing with me! |
Also allows a local
kubeconfigto be passed into for easier testing.