core: Read mon secret from file instead of env var #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisn
force-pushed
the
secret-as-file
branch
5 times, most recently
from
7507016
to
359f036
Compare
Environment variables are not recommended for secrets in pods since they can be easily leaked if the environemnt variables are logged. By mounting the mon secret as a file, the mgr and osd prepare pods can read the mon secret from a file for better security. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
secret-as-file
branch
from
359f036
to
0824b62
Compare
The toolbox, toolbox job, and osd prepare jobs need to mount the ceph admin keyring as a file instead of using an env var. The toolbox script will still allow setting of the env var for backward compatibility, though all the examples are now updated to use the keyring as a file. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
travisn
force-pushed
the
secret-as-file
branch
from
0824b62
to
4f77664
Compare
BlaineEXE
reviewed
Dec 15, 2022
Comment on lines
+201
to
+204
| if err := readCephSecret(path.Join(mon.CephSecretMountPath, mon.CephSecretFilename)); err != nil { | ||
| rook.TerminateFatal(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we really need these? If the deployment defines an env var, then that version will reference the env var, and if it defines the file, then it will use the file, right? Is there some other behavior I've forgotten where Rook needs to read that info?
There was a problem hiding this comment.
For the mgr side car and the osd prepare job, their pod specs are controlled by the operator of the same version, so we know that those will be using the secret file. But the osd purge job could have a spec with the env vars, or it could have the secret mounted, depending on the version. So this helper will use the fallback to the env var, really just to cover that osd purge job case.
BlaineEXE
approved these changes
Dec 15, 2022
mergify bot
added a commit
that referenced
this pull request
Dec 15, 2022
core: Read mon secret from file instead of env var (backport #11434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Environment variables are not recommended for secrets in pods since they can be easily leaked if the environemnt variables are logged. By mounting the mon secret as a file, the mgr and osd prepare pods can read the mon secret from a file for better security.
This in addition to #11331 should mean rook is compliant with not using the secrets.
The one exception to this is that the CSI driver and many of the Ceph pods mount the
rook-ceph-configsecret, but it does not contain confidential information. The secret only contains the mon endpoints, which is necessary to save as a secret for the csi driver.And the decoded secret:
Which issue is resolved by this Pull Request:
Resolves #10994
Checklist:
skip-cion the PR.