Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: fix topologyAware support #4099

Merged
merged 1 commit into from
Oct 16, 2019
Merged

ceph: fix topologyAware support #4099

merged 1 commit into from
Oct 16, 2019

Conversation

mateuszlos
Copy link
Contributor

@mateuszlos mateuszlos commented Oct 15, 2019 •
edited by travisn
Loading

add missing env variables to OSD pods

Signed-off-by: Mateusz Los los.mateusz@gmail.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #4101

Checklist:

  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.
  • Comments have been added or updated based on the standards set in CONTRIBUTING.md
  • Add the flag for skipping the CI if this PR does not require a build. See here for more details.

[test ceph]

leseb
leseb requested changes Oct 15, 2019
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a better commit message. Thanks.

leseb
leseb previously requested changes Oct 15, 2019
View reviewed changes
Copy link
Member

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit tests.

travisn
travisn approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could simplify by only using envVars for all containers instead of maintaining a separate configEnvVars, but we can leave that discussion for another day...

@mateuszlos @travisn
ceph: add OSDs to proper buckets in crush hierarchy while deployment
cb52aea 
add missing topologyAware and location env variables to OSD pods

Signed-off-by: Mateusz Los <los.mateusz@gmail.com>
@travisn travisn dismissed leseb’s stale review October 16, 2019 00:40

Feedback was addressed

@travisn travisn merged commit 62c15d5 into rook:master Oct 16, 2019
@mergify mergify bot mentioned this pull request Oct 16, 2019
Merged
mergify bot added a commit that referenced this pull request Oct 16, 2019
@mergify
Merge pull request #4108 from rook/mergify/bp/release-1.1/pr-4099
05f21e0 
ceph: fix topologyAware support (bp #4099)
@mateuszlos mateuszlos deleted the ceph_fix_topologyaware branch October 16, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@leseb leseb leseb left review comments

Assignees
No one assigned
Labels
ceph main ceph tag ceph-osd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ceph OSD gets neither zone nor region when using topologyAware
3 participants
@mateuszlos @leseb @travisn