Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs #5

Closed
rooklift opened this issue May 9, 2021 · 2 comments
Closed

Tabs #5

rooklift opened this issue May 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@rooklift
Copy link
Owner

rooklift commented May 9, 2021

Tabs would be awesome to have - perhaps create a new one by middle-clicking on a move. It should fit into our current system relatively easily, switching tab will just require a call to set_node() like any other change of position.

Really a tabs list is just a list of bookmarked nodes that one can click on to go to. We also need to keep track of which tab we're in, so that the particular tab we're in gets its "bookmark" updated every time it changes.

Maybe show icons of their boards for all background tabs, while the current one just gets a > sign or something.

@rooklift rooklift added the enhancement New feature or request label May 9, 2021
@rooklift
Copy link
Owner Author

rooklift commented May 9, 2021

The plan:

  • Have a map (possibly empty) of id_string --> bookmarked node
  • The current position is not one of the bookmarks (except by accident)
  • When drawing the list of bookmarks, sort them by id (same result as sorting by creation time)
  • When drawing the list of bookmarks, insert a lacuna for the current position

@rooklift
Copy link
Owner Author

rooklift commented May 9, 2021

Hmm that doesn't quite work, people will expect to be able to have multiple tabs for the same position. So it can't be a map of id --> node.

We'll have to use an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant