Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns with empty names #123

Closed
omenSi opened this issue Jan 8, 2024 · 2 comments
Closed

Columns with empty names #123

omenSi opened this issue Jan 8, 2024 · 2 comments

Comments

@omenSi
Copy link
Collaborator

omenSi commented Jan 8, 2024

Hello,

It may be my personal opinion, but it seems non logical to have table columns with empty names.

Currently, tablite allows to have a column with an empty name (or just a whitespace).

I would expect to receive an exception telling me, that "column name cannot be empty".

>>> from tablite import Table
>>> t = Table()
>>> t[""] = [1, 2, 3]
>>> t.show()
+==+=+
|# | |
+--+-+
| 0|1|
| 1|2|
| 2|3|
+==+=+
@root-11
Copy link
Owner

root-11 commented Jan 30, 2024

@omenSi Table column names can also be tuples, so we ( @root-11 & @realratchet ) think the validation of column names should be left to the user.

Will you be okay with that?

@omenSi
Copy link
Collaborator Author

omenSi commented Jan 30, 2024

I guess we will just have to deal with that on our end.

@omenSi omenSi closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants