-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.30] diverging branches of the release notes #14439
Comments
I don't think we have a guideline yet for this very specific case. I think in practice, for the majority of cases we try to merge changes in master and then backport. |
Let's imagine an example. I fix an issue for 6.32, and it is automatically collected and added to the 6.32 Release Notes. Furthermore i add a custom message to 6.32relnotes in the e.g. roofit section. I then backport the fix to 6.30. However, this time, the custom message in relnotes will not be automatically added to the 6.30 Release Notes because it was already released. So, after backporting the fix from master to 630, should one: a) Create a new PR for the 630_ReleaseNotes file, but on the master branch and then after merging, backport it to 6.30 branch |
This might not be specific enough. The release notes for the already released version of v6.30 (let's say v6.30.04) are frozen by definition. However the fix should be properly pickup by the release procedure for the next version, i.e. v6.30.06. (of course this require adding the proper tag to the issue). What am I missing? |
Thanks for the message. |
I propose to close this issue as clarified: I agree that the solution is to make backporting as easy as possible (#14889) to avoid these cases. We can focus our attention to the automation. |
Explain what you would like to see improved and how.
The release notes of 6.30, see e.g. d9c7887 are diverging for master vs 6.30 patches.
Some new changes have been implemented only in v630patches, others are only added to master. As a result, it has become a bit messy, and changes that should appear on the ROOT website release notes are not appearing because they should have been backported to 6.30
On the other hand, an easy backport is not doable because new changes were done directly on 6.30patches without doing them on master, so we would need to use 'Meld' to fuse them by hand to restore a bit the order.
Are there some common guidelines for the future on this? Like 'only do changes in 6.30 branch', or 'only do changes in master and then backport'?
ROOT version
Installation method
Binary Release
Operating system
Ubuntu 22.04
Additional context
No response
The text was updated successfully, but these errors were encountered: