Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next: switch to pest, enable globals, fix errors/exception handling. #122

Merged
merged 35 commits into from
Oct 31, 2021
Merged

Next: switch to pest, enable globals, fix errors/exception handling. #122

merged 35 commits into from
Oct 31, 2021

Conversation

QWp6t
Copy link
Sponsor Member

@QWp6t QWp6t commented Oct 30, 2021 •
edited
Loading

Closes #87
Closes #100
Closes #109
Closes #110
Closes #111
Closes #112
Closes #113

QWp6t and others added 30 commits June 6, 2021 17:47
@QWp6t
fix(assets-text): type error
ed0a1b0
@QWp6t
chore(deps): update dependencies
38ef5ad
@QWp6t
chore(deps): use laravel-zero/foundation
b3837d7
@QWp6t
chore(config): remove orphaned app.globals
bf53823
@QWp6t
chore(scripts): remove unnecessary scripts
26eef4e
@QWp6t
chore(helpers): deprecate namespaced helpers
223bd86
@QWp6t
chore(deps-dev): replace brain/monkey with tmarsteel/mockery-callable…
0116be6 
…-mock
@QWp6t
chore(tests): update snapshots
8dfd804
@QWp6t
fix(bootloader): auto detect public path
5ef5222
@QWp6t
chore(tests-bundle): update stubs
9c0530f
@QWp6t
feat(bundle): silently fail css enqueue
eccd122
@QWp6t
chore(tests): update tests
09c08c5
@QWp6t
chore(bootloader): useBasePath -> setBasePath
7e25b43
@QWp6t
chore(bootloader): store instance on the class
53c840a
@QWp6t
chore(bootloader): pass application instance to callbacks
5bc80f8
@QWp6t
fix(test-wpapi): optional $initial value (e.g., actions)
a7790ea
@QWp6t
test(app): add make() tests
70fda15
@QWp6t
test(bootloader): add more tests
184ea1e
@QWp6t
build(composer): add XDEBUG_MODE to coverage script
939d9ff
@QWp6t
chore(test-phpunit): remove illuminate coverage
ef73722
@QWp6t
test(app): test boot providers
d0c3ba1
@QWp6t
test(lazyloader): get full coverage of lazy loader
6c3f720
@QWp6t
fix(bootloader): null coalesce assignment operator not available in P…
21a34e3 
…HP 7.3
@QWp6t
fix(test-stubs): __return_empty_string should return empty string
40e4321
@QWp6t
test(bootloader): ignore coverage for skipped test
26560ee
@QWp6t
test(bootloader): get new instance
23c9231
@QWp6t
fix(deps): re-add illuminate/foundation to the repo
ef4d3e8
@QWp6t
fix(deps): downgrade league/flysystem to ^1.1
03bd127
@QWp6t
chore(whoops): clean up
dd88e58
@QWp6t
test(api): define ABSPATH and WP_CONTENT_DIR
bc6fe26
@QWp6t QWp6t merged commit fe027f1 into main Oct 31, 2021
@QWp6t QWp6t deleted the next branch October 31, 2021 01:23
@stefanfisk stefanfisk mentioned this pull request Nov 1, 2021
Closed
Kilbourne
Kilbourne reviewed Nov 1, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@strarsis
Copy link
Contributor

strarsis commented Jan 9, 2022 •
edited
Loading

@QWp6t: Great work! Has this already been released (acorn) and required by Sage 10?
I just re-encountered this issue again with a recent Sage 10 theme.

@Log1x
Copy link
Sponsor Member

Log1x commented Jan 9, 2022

what issue?

@strarsis
Copy link
Contributor

strarsis commented Jan 9, 2022

@Log1x: PHP notices and warnings causes a whoops error/exception that makes the whole page unusable.

@Log1x
Copy link
Sponsor Member

Log1x commented Jan 9, 2022

this should only happen on development. we could probably use an is_admin() check though. thoughts @QWp6t ?

@strarsis
Copy link
Contributor

strarsis commented Jan 9, 2022 •
edited
Loading

@Log1x: Good point. Though this also happens for me in production 😿 (blank page then, but corresponding error log entry).

Relevant issue + workaround:
#87 (comment)
#100

@Log1x
Copy link
Sponsor Member

Log1x commented Jan 10, 2022

is this primarily happening in admin?

@strarsis
Copy link
Contributor

strarsis commented Jan 10, 2022 •
edited
Loading

No, it also happens on frontend. But most PHP notices/warnings (e.g. WooCommerce) happen in admin, so I notice them mostly there. Well, so yes, primarily it is noticeable on admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs left review comments

@Kilbourne Kilbourne Kilbourne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@QWp6t @strarsis @Log1x @retlehs @Kilbourne