Update to Illuminate 6.3, add exception handling, code clean up #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(exceptions): Add support for filp/whoops * feat(exceptions): Add a Whoops handler for the WP Rest API and AJAX * feat(exceptions): Add WP, WP_Query, and WP_Post to the Whoops PrettyPageHandler * chore(deps): Update illuminate packages to 6.3 * chore(docblocks): Add missing docblocks * chore(cs): Clean up various inconsistencies/smells in code * chore(deps): Remove unused illuminate/database package and config * chore(deps): Add filp/whoops to require-dev and suggests * chore(deps): Add missing logging config * chore(readme): Add contributing and community sections to README * chore(package): Add Log1x as an author * chore(package): Bump minimum PHP version to 7.2
LeoColomb
reviewed
Oct 29, 2019
QWp6t
requested changes
Nov 3, 2019
There was a problem hiding this comment.
Few minor issues, couple major ones. Most notably, I'd like to see the Exception handling stuff be optional, and I don't think we should be overriding WordPress core behavior without providing an easy way to opt out of it.
I didn't review the exception handling classes beyond just looking at the Bootstrap file, and I didn't download the PR and confirm nothing is broken.
fix(exceptions): Return early in exception handler if not in development chore(database): Restore default config/database.php chore(config): Change default APP_NAME to the blog name chore(config): Fix calls to WP_ENV chore(config): Change app.debug to WP_DEBUG chore(config): Set preflight false by default for parity
…f development env
QWp6t
reviewed
Nov 4, 2019
feat(exceptions): Add internal check for existence of a fatal error handler fix(exceptions): Appropriately bail if app.debug is false fix(exceptions): Determine verbosity of debugging by environment fix(sage): Ensure the Sage provider is always loaded if the Asset or Blade providers are loaded fix(exceptions): Use the Application contract instead of Acorn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filp/whoopsWP,WP_Query, andWP_Postto the WhoopsPrettyPageHandlerilluminate/databasepackage and configfilp/whoopstorequire-devandsuggest