Add MU plugin that customizes "Background updates" site health test #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcaskill
changed the title
mcaskill
force-pushed
the
feature/bedrock-site-health-tests
branch
from
796e076
to
ba4758b
Compare
mcaskill
force-pushed
the
feature/bedrock-site-health-tests
branch
from
ba4758b
to
13bf8e7
Compare
Overrides the result of the finished "Background updates" test to avoid conflict with the way Bedrock is structured (where WordPress is managed by Composer/VCS).
Replaced hooks closures with functions to make it easier to remove, replace, reuse, or extend if needed. Added type-hinting for static analysis tools (tested with PHPStan and Psalm). Improved description of test result to support potential edge case where the result data has no description during override process.
mcaskill
force-pushed
the
feature/bedrock-site-health-tests
branch
from
13bf8e7
to
77965b1
Compare
|
If you want to make a Composer package out of this I'd be happy to add it to our docs, but this isn't something we will be adding in Bedrock at this time |
|
Hi @mcaskill, I saw you thumbed up the idea of making a package from your PR, did you already ? |
|
Hi @axi, I have not had the chance to make a package out of this; completely forgot about this pull request. I'll consider it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is based on #540 and partially resolves #522 but instead of removing the "Background updates" test, this plugin alters its status, label, and description, to explain why its disabled.