Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline phpcs rules instead of phpcs.xml #455

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

Log1x
Copy link
Sponsor Member

@Log1x Log1x commented Aug 7, 2019

  • Opinionated change: Lets us take a file out of version control while still maintaining near-identical linting rules.

@swalkinshaw swalkinshaw merged commit 7cc3b24 into master Aug 7, 2019
@swalkinshaw
Copy link
Member

Agreed this is better 👍

@swalkinshaw swalkinshaw deleted the log1x-phpcs branch August 7, 2019 12:14
@austinpray
Copy link
Contributor

I actually don’t like this change at all. I end up adding a ton of exclusions so third party plugins aren’t scanned. The rules as-is will scan the plugins dir. it doesn’t make sense to add a bunch of those exclusions as cli args in a json file.

@tangrufus
Copy link
Contributor

tangrufus commented Aug 7, 2019

I actually don’t like this change at all.

Same here.

Having phpcs.xml is easier to use custom standards.

@austinpray
Copy link
Contributor

Maybe we take this to revert town #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants