Skip to content

Commit

Permalink
馃┕ fix: server is not a constructor (#1976)
Browse files Browse the repository at this point in the history
Also removes `react` from `@roots/bud-support` peerDependencies (since we don't want it overridden there, ref #1974)

refers:

- Fixes #1975

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
  • Loading branch information
kellymears committed Jan 2, 2023
1 parent e0e2829 commit b4e4037
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
4 changes: 2 additions & 2 deletions sources/@roots/bud-server/src/server/https.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type {RequestListener} from 'node:http'
import {createServer, Server as HttpsServer} from 'node:https'

import type {Server} from '@roots/bud-framework/services'
import type {Connection} from '@roots/bud-framework/services/server'
import {BaseServer} from '@roots/bud-server/server/base'
import {bind} from '@roots/bud-support/decorators'

Expand All @@ -10,7 +10,7 @@ import {bind} from '@roots/bud-support/decorators'
*
* @public
*/
export class Https extends BaseServer implements Server.Connection {
export class Server extends BaseServer implements Connection {
/**
* Server instance
*
Expand Down
4 changes: 0 additions & 4 deletions sources/@roots/bud-support/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,6 @@
"parse5-htmlparser2-tree-adapter": ">=7",
"patch-console": ">=2",
"pretty-format": ">=29",
"react": "*",
"signale": ">=1",
"terser-webpack-plugin": "*",
"toml": "*",
Expand Down Expand Up @@ -330,9 +329,6 @@
"pretty-format": {
"optional": true
},
"react": {
"optional": true
},
"signale": {
"optional": true
},
Expand Down
3 changes: 0 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6947,7 +6947,6 @@ __metadata:
parse5-htmlparser2-tree-adapter: ">=7"
patch-console: ">=2"
pretty-format: ">=29"
react: "*"
signale: ">=1"
terser-webpack-plugin: "*"
toml: "*"
Expand Down Expand Up @@ -7032,8 +7031,6 @@ __metadata:
optional: true
pretty-format:
optional: true
react:
optional: true
signale:
optional: true
terser-webpack-plugin:
Expand Down

0 comments on commit b4e4037

Please sign in to comment.