Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Dev server breaks when defining certs #1975

Closed
retlehs opened this issue Jan 2, 2023 · 0 comments · Fixed by #1976
Closed

[bug] Dev server breaks when defining certs #1975

retlehs opened this issue Jan 2, 2023 · 0 comments · Fixed by #1976
Labels
bug Something isn't working

Comments

@retlehs
Copy link
Sponsor Member

retlehs commented Jan 2, 2023

Describe the issue

https://bud.js.org/guides/general-use/dev-server#configuring-ssl

Passing cert and key to the dev server results in an error

Props to @daverobertson for bringing this to our attention

Expected Behavior

Dev session starts

Actual Behavior

TypeError 

Server is not a constructor

Steps To Reproduce

  1. Configure a Bud project with certs
   .proxy('https://example.test')
    .serve({
      host: 'example.test',
      cert: app.path('/path/to/cert.crt'),
      key: app.path('/path/to/key.key'),
    })

version

6.6.7+

@retlehs retlehs added the bug Something isn't working label Jan 2, 2023
@kodiakhq kodiakhq bot closed this as completed in #1976 Jan 2, 2023
kodiakhq bot pushed a commit that referenced this issue Jan 2, 2023
Also removes `react` from `@roots/bud-support` peerDependencies (since we don't want it overridden there, ref #1974)

refers:

- Fixes #1975

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant