Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 fix(@roots/bud-react): allow overriding react version #1974

Merged
merged 15 commits into from
Jan 2, 2023
Merged

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented Jan 1, 2023

  • we use vadimdemedes/ink which is stuck on react < 18.
  • development on ink has slowed due to the situation in ukraine but it looks like they're prepping a release for react 18
  • in the meantime i went through and ensured all references to React umd point to @roots/bud-support/react
  • set up a reproduction with react 18
  • no changes needed in config
  • merged ✨ improve: peer dependencies vendoring #1973 onto this since they are similar in many ways

Unrelated (housekeeping)

refers:

Type of change

PATCH: backwards compatible change

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

Adds

  • none

Removes

  • none

@kellymears kellymears changed the title 🩹 fix(@roots/bud-react): allow overriding react 18 peer deps 🩹 fix(@roots/bud-react): allow overriding react version Jan 1, 2023
@github-actions github-actions bot added the docker label Jan 2, 2023
@kellymears
Copy link
Member Author

❯ yarn why react                                                                

[1/4] 🤔  Why do we have the module "react"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "react@18.2.0"
info Has been hoisted to "react"
info Reasons this module exists
   - Specified in "dependencies"
   - Hoisted from "@roots#sage#@roots#bud-preset-wordpress#@roots#bud-react#react"
info Disk size without dependencies: "388KB"
info Disk size with unique dependencies: "420KB"
info Disk size with transitive dependencies: "448KB"
info Number of shared dependencies: 2
=> Found "@roots/bud-support#react@17.0.2"
info This module exists because "@roots#bud#@roots#bud-support" depends on it.
✨  Done in 0.29s

Way To Go Thumbs Up - yyZRSvISN1vvW

@kellymears kellymears added the 🚀! automerge label Jan 2, 2023
@kodiakhq kodiakhq bot merged commit e0e2829 into main Jan 2, 2023
@kodiakhq kodiakhq bot deleted the react-peer branch January 2, 2023 13:07
kodiakhq bot pushed a commit that referenced this pull request Jan 2, 2023
Also removes `react` from `@roots/bud-support` peerDependencies (since we don't want it overridden there, ref #1974)

refers:

- Fixes #1975

## Type of change

**PATCH: backwards compatible change**



This PR includes breaking changes to the following core packages:

- none

This PR includes breaking changes to the follow extensions:

- none

## Dependencies

### Adds

- none

### Removes

- none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment