Add support for assets on both dev + default servers

[mike-sheppard]

Hey folks 👋 this is a follow-up on the discord chat + discourse forum thread to track progress in one place. Appears this will take some time to resolve as it depends on Acorn v3+ release as potentially includes breaking changes.

Issue: when running the dev server, local assets (specifically dynamic imports) on the host domain do not load + errors are logged to the console

Uncaught SyntaxError: expected expression, got '<'

Running yarn dev

• localhost:3000 ✅ assets load perfectly
• example.test ❌ assets fail to load (ideally would like this to still serve assets even if they're not 'live reloaded')

Running yarn build

• example.test ✅ assets load perfectly

[kellymears]

With acorn v3, as of right now:

export default async bud => {
  bud
    .extensions.remove(`@roots/sage/acorn`)
    .setPublicPath(`/app/themes/roots/public/`)
    // ....
})

preliminary testing indicates that this works for build and dev.

[kellymears]

This should be fixed in v6.6.0. There is no good way for bud.js to be sniff out the acorn version in use so you will need to opt-in:

bud.sage.setAcornVersion('v3')

• https://bud.js.org/releases/6.6.0/#-fix-proxy-assets-load-when-in-dev-mode

[kellymears]

OK, as of 6.6.8 you no longer need to call bud.sage.setAcornVersion and development builds work in both the context of the dev server and the proxy server (publicPath is the same in both environments).

[mike-sheppard]

Started on a new site today and this is all working perfectly! 🎉 just wanted to say thanks