fix: font rule #860
Merged
fix: font rule #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
- adds sync filter: `'config.override'` (`build` namespace is reserved for compiler)
- modifies`bud.config` to pass built config to `bud.hook.on('config.override')` event.
- this happens directly before `bud.build` verifies the configuration (strips `undefined` and `null` values)
- `bud.override` is just an alias for `bud.config`.
- fix: `hooks.filter` and `hooks.promised` will now tap the function passed to them if the supplied value is a `CallableFunction` type
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
kellymears
added
bug
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@retlehs you are better at frontend than me. does this seem right to you?
Type of change
Dependencies added
Details
Fonts are currently incorrectly set to use the
resolve-urlloader.This change loads fonts using the Webpack 5
assettype.url()ref #822