Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "default" button for grid classes settings #23

Closed
johnraz opened this issue Apr 8, 2011 · 6 comments
Closed

Adding a "default" button for grid classes settings #23

johnraz opened this issue Apr 8, 2011 · 6 comments
Assignees

Comments

@johnraz
Copy link
Contributor

johnraz commented Apr 8, 2011

Yesterday while testing the different grid framework, I was thinking it would be nice to have a "default" button right next to the Class for #main and Class for #sidebar fields in the settings pane.

The button would obviously load the default value for the currently selected grid framework.
Any thoughts ?
If you find it useful I'll implement it right away.

@retlehs
Copy link
Member

retlehs commented Apr 8, 2011

definitely useful! i wish we could knock out issue #5 (and #6) as well though

@retlehs
Copy link
Member

retlehs commented Apr 20, 2011

added this as part of #5

@retlehs retlehs closed this as completed Apr 20, 2011
@retlehs retlehs reopened this Jun 30, 2011
@retlehs
Copy link
Member

retlehs commented Jun 30, 2011

never actually implemented this (oops) and need to!

http://gregpettit.ca/2011/roots-initial-switch-to-1140/

we could do it via javascript and just update the inputs when you select different frameworks

@ghost ghost assigned swalkinshaw Jun 30, 2011
@johnraz
Copy link
Contributor Author

johnraz commented Jul 1, 2011

I can do it this sunday if you want. Quick job.

@swalkinshaw
Copy link
Member

This was taken care of with the CSS framework rewrite in af89a57.

If you click on any of the frameworks, the input + text below changes to the default classes. If you had previously changed the classes to something custom, they are remembered (but only for the previously selected framework).

@johnraz
Copy link
Contributor Author

johnraz commented Jul 11, 2011

That sounds great - And I sound like full of promisses and never doing shit :-o ! Too much on my mind lately ;(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants