Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unark should permit custom table names and/or enforce SQL-valid names #18

Closed
cboettig opened this issue Sep 25, 2018 · 0 comments
Closed

Comments

@cboettig
Copy link
Member

Currently, unark() takes the table name as the basename of the .csv file. This name may not be SQL-compliant, leading to quoting, which is a bit of a mess.

  • unark() should strip out non-compliant characters by default.
  • unark() should also be more flexible, allowing the user to specify the corresponding table names manually, rather than enforcing they correspond with the incoming csv names.
cboettig added a commit that referenced this issue Sep 25, 2018
- `unark()` will strip out non-compliant characters by default.

- `unark()` is also be more flexible, allowing the user to specify the corresponding table names manually, rather than enforcing they correspond with the incoming csv names. [#18](#18)

- Technical tweak: readLines call inside `unark()` method will use encoding directly from `getOption("encoding")`, e.g. allowing encoding to be set to UTF-8.

This can resolve parsing errors when using the readr parser on certain files.  See `FAO.R` example in `examples` for an illustration.

cc @noamross
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant