tweaks to unark for more robust parsing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `unark()` will strip out non-compliant characters by default. - `unark()` is also be more flexible, allowing the user to specify the corresponding table names manually, rather than enforcing they correspond with the incoming csv names. [#18](#18) - Technical tweak: readLines call inside `unark()` method will use encoding directly from `getOption("encoding")`, e.g. allowing encoding to be set to UTF-8. This can resolve parsing errors when using the readr parser on certain files. See `FAO.R` example in `examples` for an illustration. cc @noamross
Though based on stringi:stri_enc_detect, encoding may actually be ISO-8859-2 instead of ISO-8859-1 (latin1)? Though that causes other parsing errors...
stringi's guess was correct, we just needed to use R's short name instead of the official encoding name in `options`.
also adds ability for unark to guess csv vs tsv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unark()will strip out non-compliant characters by default.unark()is also be more flexible, allowing the user to specify the corresponding table names manually, rather than enforcing they correspond with the incoming csv names. #18Technical tweak: readLines call inside
unark()method will use encoding directly fromgetOption("encoding"), e.g. allowing encoding to be set to UTF-8.This can resolve parsing errors when using the readr parser on certain files. See
FAO.Rexample inexamplesfor an illustration.cc @noamross thanks for reporting these issues and maybe for testing this out too.