Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction between MRCA prior and clock models in one place #40

Closed
richelbilderbeek opened this issue Jul 21, 2018 · 1 comment
Closed

Comments

@richelbilderbeek
Copy link
Member

Feedback bjoelle

I found it confusing that the code relative to the interaction of MRCA priors and clock models is in a different place for strict and relaxed clocks, and it seems to have led to different behaviour between the 2 clocks (see comments in Functionality section). I would recommend putting everything in the mrca_prior_to_xml functions.

@richelbilderbeek
Copy link
Member Author

I agree that that would be nice. As there is no higher-level architecture and testing is done by reproducing files, all I can do is wiggle in those MRCA lines at the places needed.

Dicussion about architecture is here: #38

Closing this Issue, as I do agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant