Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider glue for wildcards #424

Closed
wlandau opened this issue Jun 19, 2018 · 3 comments
Closed

Consider glue for wildcards #424

wlandau opened this issue Jun 19, 2018 · 3 comments

Comments

@wlandau
Copy link
Member

wlandau commented Jun 19, 2018

https://github.com/tidyverse/glue. glue_data() should allow expansion over a grid of wildcards. Could either simplify/extend the internals or replace the wildcard interface entirely. Ref: #235.

@wlandau
Copy link
Member Author

wlandau commented Jun 19, 2018

So glue is not likely to change how users supply wildcard placeholders. Curly braces are a good idea in principle, but they are not compatible with drake_plan()

drake_plan(x = my_{func}_tion())
#> Error: unexpected '{' in "drake_plan(x = my_{"

@wlandau
Copy link
Member Author

wlandau commented Jun 19, 2018

Inside evaluate_plan(), we could just pre-wrap the wildcards in curly braces and then evaluate them with glue.

@wlandau
Copy link
Member Author

wlandau commented Jun 19, 2018

After #235 (comment) and e5579b4, I am not sure glue is the answer. The main advantage at this point is performance, and wildcards are already a fast part of drake. I may revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant