Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default EML version to 2.1.1 until 2.2.0 is officially released #31

Closed
jeanetteclark opened this issue Feb 7, 2019 · 4 comments · Fixed by #32
Closed

change default EML version to 2.1.1 until 2.2.0 is officially released #31

jeanetteclark opened this issue Feb 7, 2019 · 4 comments · Fixed by #32

Comments

@jeanetteclark
Copy link
Contributor

jeanetteclark commented Feb 7, 2019 •
edited
Loading

I know there are workarounds for this, but I would rather not have to set global options every time I spin up an R session (or change my .Rprofile) for this. For those of us (which may just be me!) testing this package regularly it would be nice to have the default version be 2.1.1 until 2.2.0 is officially out and supported by DataONE
@cboettig cboettig mentioned this issue Feb 23, 2019
Merged
@jeanetteclark
Copy link
Contributor Author

thanks Carl!

@jeanetteclark jeanetteclark mentioned this issue Sep 27, 2019
Closed
@jeanetteclark jeanetteclark mentioned this issue Oct 10, 2019
Closed
3 tasks
@cboettig cboettig reopened this Oct 10, 2019
@cboettig
Copy link
Member

ah, right, this was going the other way -- now maybe a good time to reverse it and go back to 2.2.0 as the default, yes?

@amoeba
Copy link
Contributor

amoeba commented Oct 10, 2019

2.2.0 should be the default on master after #40. Is anyone not seeing that?

@cboettig
Copy link
Member

yup, it is, I saw the change in https://github.com/ropensci/emld/pull/40/files#diff-66a2f207a5d0d3070029a1346bada357R14 but didn't put 2 and 2 together at first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use eml_version() to set version ropensci/emld
3 participants
@amoeba @cboettig @jeanetteclark