Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #41

Closed
3 tasks done
cboettig opened this issue Oct 10, 2019 · 6 comments · Fixed by #42
Closed
3 tasks done

New release? #41

cboettig opened this issue Oct 10, 2019 · 6 comments · Fixed by #42

Comments

@cboettig
Copy link
Member

cboettig commented Oct 10, 2019

This is just a follow-up on PR #40 to discuss issues for a new release.

@jeanetteclark
Copy link
Contributor

here is the (closed) issue: #31
I'm suggesting reversing that now that EML 2.2.0 is released

@amoeba
Copy link
Contributor

amoeba commented Oct 10, 2019

Would changing the NS from 2.1.1 to 2.2.0 represent a breaking change? The user-facing API looks version-independent. EML 2.1.1 -> 2.2.0 itself is a backwards compatible shift schema-wise. I'd say 0.3 is fine.

I'll PR this in a few.

@cboettig
Copy link
Member Author

Thanks. I think the only thing that would break is if you had been previously generating EML 2.2.0 using emld -- I think you'd run into trouble parsing / validating etc. But I suppose that counts as a bugfix since the eml:// namespace is essentially invalid in 2.2.0, yes? In any event, since it wasn't the default behavior it is probably an edge case. So I'm happy just calling this 0.3.0 on account of the new default behavior to 2.2.0.

@amoeba amoeba mentioned this issue Oct 10, 2019
@cboettig
Copy link
Member Author

Thanks @amoeba ! @jeanetteclark 2.2.0 is also now the default version,
https://github.com/ropensci/emld/pull/40/files#diff-66a2f207a5d0d3070029a1346bada357R14

Will send this up to CRAN

@amoeba
Copy link
Contributor

amoeba commented Oct 10, 2019

Thanks @cboettig and @jeanetteclark!

@cboettig
Copy link
Member Author

v0.3.0 is now on CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants