cred_ssh_key() defaults

[ijlyttle]

Fixes #314

Adds a function ssh_path(), in the footsteps of @jennybc's git_user_dot_home()

Puts that function to use for the defaults in cred_ssh_key().

I don't see a test-file for credentials - I could add one if you think it useful.

Signed only most-recent commit, due to late reading of contribution guidelines.

[jennybc]

@ijlyttle So if you install this version of git2r, does it have the effect you'd hope in this exercise re: usethis::use_github()? I think it should make all the friction go away ... perhaps up to the passphrase issue.

[ijlyttle]

@jennybc I still can't get ssh-agent to work, so this will be (my) immediate path to success on Windows:

usethis::use_github(credentials = git2r::cred_ssh_key())

It does not yet work - I think this has to do with #312

Error in git2r::push(r, "origin", "refs/heads/master", credentials = credentials) : 
  Error in 'git2r_push': 'credentials' must be a S4 class with credentials

> str(git2r::cred_ssh_key())

List of 3
 $ publickey : chr "C:\\Users\\username\\.ssh\\id_rsa.pub"
 $ privatekey: chr "C:\\Users\\username\\.ssh\\id_rsa"
 $ passphrase: chr "*****"
 - attr(*, "class")= chr "cred_ssh_key"

[stewid]

@ijlyttle Thanks. I think I need about a week to finish #312

[stewid]

@ijlyttle I have merged #312. Could you please try again.
Thanks

[ijlyttle]

rebasing now - will test asap

[jennybc]

Whatever happened here Git-wise isn't ... quite done yet? @ijlyttle it's hard to see your changes, amidst all the others. Can you update your master branch from master on ropensci/git2r, rebase your PR branch onto that, then force push to your PR branch?

[ijlyttle]

@jennybc I rebased onto master on ropensci/git2r - although it took some convincing. Is it looking any better?

If it is well-and-truly hosed, I can start the PR again from scratch - my changes were not that many.

[ijlyttle]

@stewid I have installed f8ec75e on both my Mac and PC, and I run:

git2r::push(".", "origin", "refs/heads/master", credentials = git2r::cred_ssh_key())

On the Mac, it seems to work OK.

On the PC, I get a strange error:

Error in is_detached(repo) : 
  Error in 'git2r_repository_head_detached': Invalid repository

The repo is otherwise normal (from the terminal git status says all is well)

[ijlyttle]

closing in favor of #317