Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Change S4 classes to S3 #313

Merged
merged 64 commits into from
Jan 29, 2018
Merged

[WIP] Change S4 classes to S3 #313

merged 64 commits into from
Jan 29, 2018

Conversation

stewid
Copy link
Member

@stewid stewid commented Jan 18, 2018 •
edited
Loading

  • cred_env
  • cred_ssh_key
  • cred_token
  • cred_user_pass
  • git_blame
  • git_blame_hunk
  • git_blob
  • git_branch
  • git_commit
  • git_diff
  • git_diff_file
  • git_diff_hunk
  • git_diff_line
  • git_fetch_head
  • git_merge_result
  • git_note
  • git_reference
  • git_reflog_entry
  • git_repository
  • git_signature
  • git_stash
  • git_tag
  • git_time
  • git_transfer_progress
  • git_tree

@stewid
Remove 'R/S4-classes.R'
b7940e7 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r argument checking in C to handle S3 classes
b8bec9e 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r C code for a git_branch to S3
089d8d2 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change default repo argument in ls_tree to '.'
95d3785 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r C code for a git_blame object to S3
ef21bfe
@stewid
Change git2r 'git_repository' object to S3 class
594341a 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r C code for a git_signature object to S3
843d19b 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r 'git_signature' object to S3 class
4de21ac 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r 'git_commit' object to S3 class
b49142a 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
f94851e 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
101888d 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update some tests to handle S3 classes
8628585 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Code style
180ac00 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Add missing class name
6c25870 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change default repo argument in 'commit' and 'commits' to '.'
86cbf59 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r C code for a git_tree object to S3
953647f 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change C function 'git2r_object_lookup' to work with S3 classes
2739b7d 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r 'git_fetch_head' object to S3 class
1121ec5 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Fix broken branch tests
7c56f78 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Cleanup
1d527fd 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change 'git_blame' object to S3 class
cc55b0a 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
roxygen: remove linkS4class
c20f484 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
NAMESPACE: remove 'exportClasses'
c59365f 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
roxygen: remove 'include S4_classes.R'
a0fc222 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
fa43f55 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change 'git_tag' object to S3 class
404349c 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change plot method to S3
1ebf41b 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Remove depends 'methods' in DESCRIPTION
d177ef2 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change 'git_note' object to S3 class
dcfe644 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
55832b4 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
0a0fa25
@stewid
Remove use of slot method in tests
e779eaa 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
More work to change git2r C code to work with S3 classes
3f1787f
@stewid
Change 'show' to 'print'
9400ba3 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Add missing documentation for 'is.git_blob' method
a8bfaed 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
bcf60f8 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update test
c0cb6a9 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Use 'inherits' to check class
fbdcf8d 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Fix typo
6769552 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update tests
ccb252e 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change to use 'as.data.frame'
a05c66b 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
02f2980 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Some fixes
dd985c6
@stewid
Add 'as.character.git_time' and 'as.POSIXct.git_time'
edf9878 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Refactoring of 'when' method
d43b371 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
a24c620 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git2r C code for merge to handle S3 classes
c3bb1eb 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Remove use of slot
2700b65
@stewid
Change 'git_stash' object to S3 class
93a4922 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update tests
a841d9e 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change 'git_reflog_entry' object to S3 class
f0ee6da 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update tests
d47015a 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Change git_tree index method to S3
04eaf11 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Roxygenize
dce7b5e 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update 'git2r_push.c'
008cdb5 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update tests
104472d 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Update tests for 'git_time'
9ca4808 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid
Set default NA value for git_reference target
6768d98 
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
@stewid stewid merged commit ef3261a into master Jan 29, 2018
@stewid stewid deleted the change-S4-classes-to-S3 branch January 29, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stewid