Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting ignored words #30

Closed
oloverm opened this issue Nov 3, 2017 · 2 comments
Closed

Resetting ignored words #30

oloverm opened this issue Nov 3, 2017 · 2 comments

Comments

@oloverm
Copy link

oloverm commented Nov 3, 2017

If I ignore a word with the ignore argument, it remains ignored in future checks:

> hunspell("ggggggg")
[[1]]
[1] "ggggggg"

> hunspell("ggggggg", ignore = "ggggggg")
[[1]]
character(0)

> hunspell("ggggggg")
[[1]]
character(0)

But if I ignore it with dict = dictionary(add_words = ), it doesn't stay ignored:

> hunspell("fffffff")
[[1]]
[1] "fffffff"

> hunspell("fffffff", dict = dictionary(add_words = "fffffff"))
[[1]]
character(0)

> hunspell("fffffff")
[[1]]
[1] "fffffff"

I don't know which of the two behaviours is preferable, but they should probably be consistent, and it would be good to be able to reset the words added with ignore.

@jeroen
Copy link
Member

jeroen commented Nov 3, 2017

Ah that's a caching bug. Thanks for reporting.

@jeroen jeroen closed this as completed in faf776a Nov 3, 2017
@jeroen jeroen reopened this Dec 15, 2017
@jeroen
Copy link
Member

jeroen commented Dec 16, 2017

Fixed again in 2.9.

@jeroen jeroen closed this as completed Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants