Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling http errors #23

Closed
mbojan opened this issue Oct 5, 2015 · 3 comments
Closed

Handling http errors #23

mbojan opened this issue Oct 5, 2015 · 3 comments

Comments

@mbojan
Copy link
Member

mbojan commented Oct 5, 2015

Extracted from #17.

Internet-related errors, like timeouts etc. They are thrown by httr::GET, which is used in several places, but most importantly in while_oai, which is the core of list_* functions.

  • Things like timeouts could be addressed by proper pre-configuring httr::GET (passing additional arguments through httr::config
  • Perhaps it should be possible to add an optional sleep time between requests in while_oai.
@sckott sckott modified the milestone: v0.2 Oct 5, 2015
@sckott sckott modified the milestones: v0.3, v0.2 Feb 5, 2016
@sckott sckott removed this from the v0.3 milestone Sep 6, 2019
@sckott
Copy link
Collaborator

sckott commented Sep 6, 2019

... is passed through to while_oai() so i think the user can configure this themselves. or do you think we need more than ...?

@mbojan
Copy link
Member Author

mbojan commented Sep 11, 2019

I think ... should be enough in most cases. I vaguely recall that at some point I was getting some errors and thought it was because I was making to many request too quickly, hence the second bullet above. However I think the problem was somewhere else in the end.

I believe we can close this one.

@sckott
Copy link
Collaborator

sckott commented Sep 11, 2019

ok, thanks, closing

@sckott sckott closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants