Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests tests tests! #3

Closed
mpadge opened this issue Oct 19, 2016 · 6 comments
Closed

tests tests tests! #3

mpadge opened this issue Oct 19, 2016 · 6 comments

Comments

@mpadge
Copy link
Member

mpadge commented Oct 19, 2016

Write them, and consider this issue.

@mpadge
Copy link
Member Author

mpadge commented Oct 21, 2016

First mocked tests here, but there must be a better way to define the return value from with_mock other than having to paste wholesale code from the originating function?

@mpadge
Copy link
Member Author

mpadge commented Oct 24, 2016

@n-s-f Just a expression of gratitude for your excellently programmed mockery package which I've also praised in this ROpenSci discussion. I've also incorporated your stub.R code within this package and acknowledged your contribution - thanks!

@Robinlovelace - you might be interested to see how much cleaner these tests are using stub rather than with_mock. This will be the basic structure of all tests from hereon. Any further suggestions appreciated ...

@nsfinkelstein
Copy link

@mpadge Thanks so much for the kind words! I'm glad you're finding the code useful.

@mpadge
Copy link
Member Author

mpadge commented Oct 24, 2016

@n-s-f just found about from @sckott about his webmockr package. Just in case either of you weren't aware of the other ...

@nsfinkelstein
Copy link

@mpadge Thanks for the heads up! Hadn't seen it. @sckott, this looks very cool.

@sckott
Copy link

sckott commented Oct 24, 2016

hi all, webmockr targets mocking http requests, so no overlap i don't think

@mpadge mpadge closed this as completed Dec 19, 2016
@mpadge mpadge mentioned this issue Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants