Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ggplot2 dev #264

Closed
wants to merge 17 commits into from
Closed

Fix ggplot2 dev #264

wants to merge 17 commits into from

Conversation

cpsievert
Copy link
Collaborator

The development version of ggplot2 has shifted from proto objects to "ggproto" objects. That change breaks some assumptions we were making about the structure of ggplot objects.

@cpsievert
Copy link
Collaborator Author

Hey @chriddyp, does RTestBot3000 have a limit on the number of figures? I'm getting a bunch of server errors -> https://travis-ci.org/ropensci/plotly/builds/75853479

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/75859950

On TravisCI, commit b395eb4 was successfully merged with 1bd2e70 (master) to create b3ee71a. A visual testing table comparing 1bd2e70 with b3ee71a can be found here ->

http://cpsievert.github.io/plotly-test-table/R/b3ee71a/

Detected 0 differences

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/75860867

On TravisCI, commit b395eb4 was successfully merged with 1bd2e70 (master) to create a4d3d75. A visual testing table comparing 1bd2e70 with a4d3d75 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/a4d3d75/

Detected 0 differences

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/75953419

On TravisCI, commit d1db211 was successfully merged with 1bd2e70 (master) to create 6ac8ae0. A visual testing table comparing 1bd2e70 with 6ac8ae0 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/6ac8ae0/

Detected 0 differences

@cpsievert
Copy link
Collaborator Author

Abandoning this effort in favor of #269

@cpsievert cpsievert closed this Sep 4, 2015
@cpsievert cpsievert deleted the fix-ggplot2-dev branch November 20, 2015 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant