Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homr qid search fails #404

Closed
djhocking opened this issue Nov 17, 2021 · 2 comments
Closed

homr qid search fails #404

djhocking opened this issue Nov 17, 2021 · 2 comments

Comments

@djhocking
Copy link
Collaborator

djhocking commented Nov 17, 2021

@sckott - I was running tests before releasing the cache fix #403 to cran. Unfortunately, the homr function doesn't seem to be working when searching by qid. I'm not sure if this is a slight change with the API to search by qid or if it's not allowed at all any more. For example, none of these work:

homr(qid = 'COOP:046742')
homr(qid = ':046742')
homr(qidMod='starts', qid='COOP:0467')

which then causes test-homr.R to fail. Other arguments to search homr work fine.

I'm not familiar with HOMR yet and am fairly new to a number of these methods of using APIs. If you have time to take a look that would be great but let me know how to proceed if there's not a suitable solution in time for the #403 CRAN release.

@sckott
Copy link
Contributor

sckott commented Nov 17, 2021

Sorry about that. I had a look. It was going through some redirects and then leading to non json data somehow.

When i changed the base url to 'https://www.ncei.noaa.gov/access/homr/services/station/' then it seemed to work.

@djhocking
Copy link
Collaborator Author

Perfect, fixed everything. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants