Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis builds fail with several errors #23

Closed
timtrice opened this issue May 3, 2017 · 12 comments
Closed

travis builds fail with several errors #23

timtrice opened this issue May 3, 2017 · 12 comments
Labels
Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW

Comments

@timtrice
Copy link
Contributor

timtrice commented May 3, 2017

When travis tests pushes there are errors and failures centered around the vignette and tests.

The most recent successful test was Build #16 on branch develop-v0.0.0.9002. This specific build only changed the first example from using the current year as the default year to using 2016.

Since, that branch has been deleted.

The contents of the .travis.yml file.

Since then, I am unable to get any builds to pass. Since I deleted the branch, I've screwed myself. Lesson learned.

This issue will deal with trying to identify what happened. All work is done in branch develop-travis.

The most recent successful pass in a branch that I still have (develop) is Build #11 which ran 2017-03-28. This issue will document attempting to pass travis again based off that commit.

@timtrice timtrice added Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW In Progress Actively under development labels May 3, 2017
@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commit c77a561 fails on Build 34.

Error seems to be on tests that pass locally.

Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  11: xml2::read_html(link)
  12: read_html.default(link)
  13: suppressWarnings(read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options))
  14: withCallingHandlers(expr, warning = function(w) invokeRestart("muffleWarning"))
  15: read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)
  
  Error in UseMethod("read_xml") : 
    no applicable method for 'read_xml' applied to an object of class "factor"
  Calls: test_check ... %>% -> eval -> eval -> <Anonymous> -> read_html.default
  testthat results ================================================================
  OK: 56 SKIPPED: 0 FAILED: 1
  1. Error: Get products from storm archive (@test_filters.R#7) 
  
  Error: testthat unit tests failed

This test had no vignettes which has been typical of what I've seen. When vignettes are present but not checked (--no-build-vignettes) or not present then these test errors seem to be the fallback.

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Thinking if xml2 in DESCRIPTION Imports may be the issue I reinstate the vignettes and remove the xml2 Import. Commit 0d0d00e, Build #35.

Test fails.

Building with: R CMD build 
4.90s$ R CMD build  .
* checking for file ‘./DESCRIPTION��� ... OK
* preparing ‘Hurricanes’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 86-87 (getting-started.Rmd) 
Error: processing vignette 'getting-started.Rmd' failed with diagnostics:
is.character(url) is not TRUE
Execution halted

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

At this point I do a git diff between current commit and 1b4cd84 (the last successful pass). Files currently in inst/docs that did not exist in 1b4cd84. Remove those(3292576, 4e129de, 9a58249). Build #36 fails.

Building with: R CMD build 
4.67s$ R CMD build  .
* checking for file ‘./DESCRIPTION��� ... OK
* preparing ‘Hurricanes’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 86-87 (getting-started.Rmd) 
Error: processing vignette 'getting-started.Rmd' failed with diagnostics:
is.character(url) is not TRUE
Execution halted

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

At this point the only difference remaining is the presence of the .gitignore file which I highly doubt is the problem but I remove it anyway (56229d5). Now only differences are cosmetic (newlines, spaces) and the travis link in the README file.

Build #37 fails.

...omfg...

Building with: R CMD build 
4.88s$ R CMD build  .
* checking for file ‘./DESCRIPTION’ ... OK
* preparing ‘Hurricanes’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 86-87 (getting-started.Rmd) 
Error: processing vignette 'getting-started.Rmd' failed with diagnostics:
is.character(url) is not TRUE
Execution halted

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Current output of git diff:

git diff 56229d5 1b4cd84
diff --git a/.travis.yml b/.travis.yml
index 53bfc5e..980767e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,5 +1,4 @@
 language: r
-
 warnings_are_errors: false
 
 r_packages:
diff --git a/README.md b/README.md
index 487bd59..68abff4 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-[![Travis-CI Build Status](https://travis-ci.org/timtrice/Hurricanes.svg?branch=travis)](https://travis-ci.org/timtrice/Hurricanes)
+[![Travis-CI Build Status](https://travis-ci.org/timtrice/Hurricanes.svg?branch=develop-v0.0.0.9002)](https://travis-ci.org/timtrice/Hurricanes)
 
 # Hurricanes

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Remove all vignette documents (commit fb0e462). Build #38 fails. Tests again. Of course...

get_storm_data 2.352  0.056   33.75
* checking for unstated dependencies in ‘tests’ ... OK
* checking tests ... ERROR
  Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  11: xml2::read_html(link)
  12: read_html.default(link)
  13: suppressWarnings(read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options))
  14: withCallingHandlers(expr, warning = function(w) invokeRestart("muffleWarning"))
  15: read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)
  
  Error in UseMethod("read_xml") : 
    no applicable method for 'read_xml' applied to an object of class "factor"
  Calls: test_check ... %>% -> eval -> eval -> <Anonymous> -> read_html.default
  testthat results ================================================================
  OK: 56 SKIPPED: 0 FAILED: 1
  1. Error: Get products from storm archive (@test_filters.R#7) 
  
  Error: testthat unit tests failed

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commit 06b54de, remove xml2 from xml2 Imports again. The previous try reinstated vignettes. Leave it out this time.

Build 39 fails. Tests again.

Last 13 lines of output:
  11: xml2::read_html(link)
  12: read_html.default(link)
  13: suppressWarnings(read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options))
  14: withCallingHandlers(expr, warning = function(w) invokeRestart("muffleWarning"))
  15: read_xml(x, encoding = encoding, ..., as_html = TRUE, options = options)
  
  Error in UseMethod("read_xml") : 
    no applicable method for 'read_xml' applied to an object of class "factor"
  Calls: test_check ... %>% -> eval -> eval -> <Anonymous> -> read_html.default
  testthat results ================================================================
  OK: 56 SKIPPED: 0 FAILED: 1
  1. Error: Get products from storm archive (@test_filters.R#7) 
  
  Error: testthat unit tests failed

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commit e7834ca removes all tests. No other changes.

Build #40 passes.

This issue could be related or helpful: r-lib/testthat#144. Save for reference.

Google Search Query

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commit 710843b, f927f4f: cosmetic changes; added .gitignore back into repo.

Build #41 passes.

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commits 2cb7d89, cb07c7c, b62405a, a711c19, 4d577f6 all reintroduce vignettes and re-add xml2 back to DESCRIPTION Imports. I got a little twisted reverting some of the vignette commits, thus so many.

Build #42 fails.

Building with: R CMD build 
5.22s$ R CMD build  .
* checking for file ‘./DESCRIPTION’ ... OK
* preparing ‘Hurricanes’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 86-87 (getting-started.Rmd) 
Error: processing vignette 'getting-started.Rmd' failed with diagnostics:
is.character(url) is not TRUE
Execution halted
The command "R CMD build  ." failed and exited with 1 during .

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Commits e499c6, 8c809b, 0662a6: attempted to reset branch to commit f927f4f. Didn't work as expected. Removed vignettes again and kept xml2 as Import.

Build #43 passes.

@timtrice
Copy link
Contributor Author

timtrice commented May 3, 2017

Closing this issue. Further checks against travis will be examined (vignette under Issue #24, tests under Issue #25)

@timtrice timtrice closed this as completed May 3, 2017
@timtrice timtrice removed the In Progress Actively under development label May 3, 2017
timtrice added a commit that referenced this issue May 3, 2017
This commit merges commit c95bbef. There are not tests or vignettes
per Issue #23, #24, and #25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugs Fix me, I'm broken! DON'T DELAY!!! High Priority NOW NOW NOW
Projects
None yet
Development

No branches or pull requests

1 participant