PR - develop-travis to develop #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my latest magic trick I'll prevent this build from passing travis. I would prefer to have the vignettes tested but at this point, whatever.
Copied silently from github bozenne/butils.base
The most recent travis build that passed used this file: https://goo.gl/zM6RO7. I have also removed vignettes and after this push will await my fate.
This reverts commit e9ce8ff.
The most recent successful travis test, https://goo.gl/XMhlnK, did not have xml2 package in the DESCRIPTION file. This test passed though because in the .travis.yml file the warnings_are_errors param is set to false. When running a R CMD check a warning is generated: ``` checking dependencies in R code ... WARNING '::' or ':::' import not declared from: ‘xml2’ ``` So, first I'll see if this tests passes. Then, if so, will address fixing the check issue.
The previous push to travis failed (Build 35). I have added xml2 back to Imports. removed getting-started.R from inst/docs and some cosmetic changes.
This reverts commit fb0e462.
This reverts commit 2cb7d89.
This reverts commit fb0e462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch does not include tests or vignettes which at the moment fail in travis (see Issue #23). This current version passes and is ready to be merged.
develop-travisis to be locked to avoid deletion. Vignettes and tests are to be reintroduced and examined to meet whatever qualifications necessary to pass. Those have been created in Issues #24 and Issues #25. The original Issue, #23, has been closed with this PR.