Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sk_print does not work for all classes #71

Closed
elinw opened this issue Jun 3, 2017 · 3 comments
Closed

sk_print does not work for all classes #71

elinw opened this issue Jun 3, 2017 · 3 comments
Labels
Needs discussion

Comments

@elinw
Copy link
Collaborator

elinw commented Jun 3, 2017

sk_print currently only handles numeric, character and factor. As a result ordered factors, dates and complex are not printing.
@elinw elinw mentioned this issue Jun 3, 2017
Closed
@elinw elinw added the question label Jun 4, 2017
@elinw
Copy link
Collaborator Author

elinw commented Jun 4, 2017 •
edited
Loading

I'm labelling this needs discussion because it requires discussion for the larger issue even if we fix some things piecemeal initially.

@elinw elinw mentioned this issue Jun 7, 2017
Closed
@elinw
Copy link
Collaborator Author

elinw commented Jun 10, 2017

I pushed a concept here.
https://github.com/ropenscilabs/skimr/blob/printconcept/R/skim_print.R

@elinw elinw mentioned this issue Jun 17, 2017
Closed
@elinw
Copy link
Collaborator Author

elinw commented Jul 12, 2017

There is now default handling and handling of most types with at least minimal statistics.

@elinw elinw closed this as completed Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elinw