Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language variable #478

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Add language variable #478

merged 5 commits into from
Nov 2, 2021

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 2, 2021

Does this look good @xuanxu?

Cc @mpadge

I'll add it to the config of the responder checking all variables are there.

Copy link
Collaborator

@xuanxu xuanxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maelle Could you please also add to stat-software template? ES version of that is still forthcoming ... Thanks!

@maelle maelle requested a review from mpadge November 2, 2021 10:56
@maelle maelle merged commit f718ec5 into master Nov 2, 2021
@maelle maelle deleted the maelle-patch-1 branch November 2, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants