Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sfr #198

Merged
merged 197 commits into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@Robinlovelace
Copy link
Collaborator

Robinlovelace commented Jun 3, 2017

No description provided.

@edzer

This comment has been minimized.

Copy link
Contributor

edzer commented on .travis.yml in 1cd9627 Dec 12, 2016

You won't need any postgresql/postgis stuff since you're not testing sf, but only installing it.

This comment has been minimized.

Copy link
Collaborator Author

Robinlovelace replied Dec 12, 2016

TRUE that - just copy pasting. Will remove.

Robinlovelace and others added some commits Dec 12, 2016

Merge pull request #164 from Robinlovelace/sfr-dep
Initial commits to sfr branch to add support for sf classes in stplanr.
Merge pull request #199 from richardellison/sfr
Add support for sf for SpatialLinesNetworks
Merge pull request #200 from mpadge/sfr
slight tidy of src/spatialnetworks.cpp
@richardellison

This comment has been minimized.

Copy link
Collaborator

richardellison commented Jun 4, 2017

@Robinlovelace Do we want to merge this branch into master now and then just work from master? If so, I'll merge this (and your other PRs).

@Robinlovelace

This comment has been minimized.

Copy link
Collaborator Author

Robinlovelace commented Jul 25, 2017

Hi @richardellison I think we can merge this now. Please take a look at my generic method for geo_projected() and geo_buffer() if you get a chance. I think we should support sf from the next release on so yes let's do it.

@Robinlovelace

This comment has been minimized.

Copy link
Collaborator Author

Robinlovelace commented Jul 25, 2017

But we should probably get the build passing first!

@richardellison

This comment has been minimized.

Copy link
Collaborator

richardellison commented Jul 25, 2017

I'll have a look to see if I can fix the build issues. Seems the issue is that in your PR RcppExports has been changed to use _stplanr_coord_matches instead of stplanr_coord_matches. Not sure why though? The rest of the references look unchanged (resulting in that error).

mpadge and others added some commits Nov 7, 2017

Merge pull request #227 from mpadge/patch-1
Update stplanr-dodgr.Rmd
Merge pull request #228 from mpadge/patch-2
Update stplanr-dodgr.Rmd
Merge pull request #229 from mpadge/sfr
implement nearest_cyclestreets.sf
Add sf method for onewaygeo
@richardellison I'm quite proud of this one: concise and effective - took a while though

@Robinlovelace Robinlovelace merged commit ff733ba into master Nov 16, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.