Sfr #198
Merged
Sfr #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commits to sfr branch to add support for sf classes in stplanr.
Add support for sf for SpatialLinesNetworks
slight tidy of src/spatialnetworks.cpp
|
@Robinlovelace Do we want to merge this branch into master now and then just work from master? If so, I'll merge this (and your other PRs). |
|
Hi @richardellison I think we can merge this now. Please take a look at my generic method for |
|
But we should probably get the build passing first! |
|
I'll have a look to see if I can fix the build issues. Seems the issue is that in your PR RcppExports has been changed to use _stplanr_coord_matches instead of stplanr_coord_matches. Not sure why though? The rest of the references look unchanged (resulting in that error). |
|
Maybe a botched merge - apologies if so. |
Update stplanr-dodgr.Rmd
Update stplanr-dodgr.Rmd
implement nearest_cyclestreets.sf
@richardellison I'm quite proud of this one: concise and effective - took a while though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.