Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: BaseProvider random_digit_not_null_or_empty() change internals #14

Closed
sckott opened this issue Mar 9, 2017 · 0 comments
Closed

review: BaseProvider random_digit_not_null_or_empty() change internals #14

sckott opened this issue Mar 9, 2017 · 0 comments
Labels
review
Milestone
v0.1

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 9, 2017

I'm curious why the digit-or-blank generators don't just sample from a larger set. The code for random_digit_not_null_or_empty() means that half of the generated items should be "". Why not sample with this instead? bp$random_element(c(1:9, ""))

good catch, will change
@sckott sckott added the review label Mar 9, 2017
@sckott sckott mentioned this issue Mar 9, 2017
Closed
13 tasks
@sckott sckott closed this as completed in 20907b3 Mar 28, 2017
@sckott sckott modified the milestone: v0.1 May 30, 2017
tjmahr added a commit to tjmahr/charlatan that referenced this issue May 31, 2017
@tjmahr
remove unneeded code for random digit methods. related to ropensci#14
5aff72e
sckott added a commit that referenced this issue May 31, 2017
@sckott
Merge pull request #43 from tjmahr/patch-1
3f78f46 
remove unneeded code for random digit methods. related to #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@sckott