Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible need to clarify where to use setInterval() function to disable updateNTP() #19

Closed
malbrook opened this issue Dec 12, 2018 · 1 comment

Comments

@malbrook
Copy link

I am using eztime as part of a multitask environment and could not understand why it was not working as expected when trying to disable the default updateNTP event. The problem is that in this case you must use the events function first before you try to disable the updateNTP event as part of the events function is to start updateNTP on the first run through even if you had already called setInterval(0). The problem is exacerbated in a multi task environment where the two tasks are running independantly.

Would help I think to make this clear in the documentation.

ropg added a commit that referenced this issue Dec 16, 2018
@ropg
Copy link
Owner

ropg commented Dec 16, 2018

Thank you for reporting this. Instead of documenting what is essentially a workaround for wrong behaviour, I just made events() not start updateNTP() if the interval has been set to zero. Version 0.7.8 has the fix.

@ropg ropg closed this as completed Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants