Add global_substitutions to fix github links #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
approved these changes
May 12, 2023
This was referenced May 12, 2023
christophfroehlich
added a commit
to christophfroehlich/control.ros.org
that referenced
this pull request
May 22, 2023
This reverts commit fed3b2a.
christophfroehlich
added a commit
that referenced
this pull request
Jun 8, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
(cherry picked from commit fed3b2a) # Conflicts: # conf.py
christophfroehlich
added a commit
that referenced
this pull request
Jun 12, 2023
christophfroehlich
added a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Edit on Github" link does not work on the cloned repositories into docs folder, like mentioned in #58
As a workaround, one can override the
github_urlon top of every included rst file:github_url: https://github.com/ros-controls/ros2_controllers/blob/master/joint_trajectory_controller/doc/userdoc.rstTo let this be maintainable, I suggest using sphinxcontrib.globalsubs to replace the branch name in the URL automatically.
I create a PR to ros2_controllers to demonstrate this.