Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom rosdoc2 config #132

Merged
merged 5 commits into from Apr 29, 2024
Merged

Add custom rosdoc2 config #132

merged 5 commits into from Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 16, 2024

rosdoc2 will be used by the build farm to publish API docs on http://docs.ros.org/en/rolling/p/control_msgs/

  • Add custom landing page for rosdoc2: logo, links to control.ros.org
  • Copy over information from https://wiki.ros.org/control_msgs
  • add rosdoc2 workflow, but only if the relevant files changed
  • remove BUILD_TESTING, because ADD_LINTER_TESTS already does the job for the generated message files.

image

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophfroehlich everything looks good to me, why do we have the Realtime Publisher as title in the image?

@christophfroehlich
Copy link
Contributor Author

@christophfroehlich everything looks good to me, why do we have the Realtime Publisher as title in the image?

oops, that was an old screenshot. I updated it.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

Copy link

mergify bot commented Apr 17, 2024

backport humble

✅ Backports have been created

@christophfroehlich christophfroehlich merged commit 3b381d1 into master Apr 29, 2024
8 checks passed
@christophfroehlich christophfroehlich deleted the rosdoc2 branch April 29, 2024 12:49
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
* Add basic rosdoc2 landing page

* Add rosdoc2 workflow

* Add correct homepage link for ros2

* Remove build_testing

* Use master branch of ros2_control_ci repo

(cherry picked from commit 3b381d1)
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
* Add basic rosdoc2 landing page

* Add rosdoc2 workflow

* Add correct homepage link for ros2

* Remove build_testing

* Use master branch of ros2_control_ci repo

(cherry picked from commit 3b381d1)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants