Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Specify runner/container images and add Jazzy jobs #134

Merged
merged 7 commits into from
May 8, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 24, 2024

Jobs for jazzy-main are failing, but jazzy-testing works fine already.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

Copy link

mergify bot commented Apr 24, 2024

backport humble

✅ Backports have been created

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could still use a matrix build using the include notation:

    strategy:
      fail-fast: false
      matrix:
        include:
          - ros_distro: iron
            os_name: ubuntu-22.04
          - ros_distro: rolling
            os_name: ubuntu-24.04

@christophfroehlich
Copy link
Contributor Author

We could still use a matrix build using the include notation:

    strategy:
      fail-fast: false
      matrix:
        include:
          - ros_distro: iron
            os_name: ubuntu-22.04
          - ros_distro: rolling
            os_name: ubuntu-24.04

ah that could be, thanks. I would need a different key for rolling container, but I give it a try

@christophfroehlich christophfroehlich changed the title [CI] Specify runner/container images [CI] Specify runner/container images and add Jazzy jobs Apr 28, 2024
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is only minor, so happy to approve.

.github/workflows/rolling-build.yml Outdated Show resolved Hide resolved
Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
@christophfroehlich christophfroehlich merged commit 0943242 into master May 8, 2024
9 of 10 checks passed
@christophfroehlich christophfroehlich deleted the ci_noble branch May 8, 2024 13:06
mergify bot pushed a commit that referenced this pull request May 8, 2024
* Specify runner/container images

* Use matrix strategy

* Add jazzy jobs

* Update upstream pre-commit wf also for humble

* Sort the distros

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 0943242)
christophfroehlich added a commit that referenced this pull request May 8, 2024
* Specify runner/container images

* Use matrix strategy

* Add jazzy jobs

* Update upstream pre-commit wf also for humble

* Sort the distros

Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de>
(cherry picked from commit 0943242)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants