Export all dependencies #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ament_export_dependencies exports dependencies to downstream packages. This is necessary so that the user of the library does not have to call find_package for those dependencies.
ahcorde
approved these changes
Feb 27, 2023
|
@Mergifyio backport master |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2023
The ament_export_dependencies exports dependencies to downstream packages. This is necessary so that the user of the library does not have to call find_package for those dependencies. (cherry picked from commit 47255ae)
ahcorde
added a commit
that referenced
this pull request
May 16, 2023
The ament_export_dependencies exports dependencies to downstream packages. This is necessary so that the user of the library does not have to call find_package for those dependencies. (cherry picked from commit 47255ae) Co-authored-by: Adrian Zwiener <a.zwiener@rethinkrobotics.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a specialized Hardware Interface for our robot, I realized that my library has compilation errors, if I do not
find_packagethe Gazebo library. This is when I realized that onlyament_cmakeandrclcppare currently exported. I took the liberty to export all dependencies currentlyfind_packaged.See also the Ament-CMake-Documentation :
Should it be possible for other user to inherit from
GazeboSystemInterfaceto create their custom interfaces?If yes, I guess we should export all the dependencies, or am I mistaken here?