Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added namespace to controller manager #147

Merged
merged 1 commit into from Jul 27, 2022

Conversation

mcbed
Copy link
Member

@mcbed mcbed commented Jul 27, 2022

Minor fix to allow CM to be run in the defined namespace, ref #122

@mcbed
Copy link
Member Author

mcbed commented Jul 27, 2022

As impl_->model_nh_->get_namespace() returns the set namespace, do we still need to search for it in the sdf ?

// Set namespace if tag is present
if (sdf->HasElement("namespace")) {
std::string ns = sdf->GetElement("namespace")->Get<std::string>();
// prevent exception: namespace must be absolute, it must lead with a '/'
if (ns.empty() || ns[0] != '/') {
ns = '/' + ns;
}
std::string ns_arg = std::string("__ns:=") + ns;
arguments.push_back(RCL_REMAP_FLAG);
arguments.push_back(ns_arg);
}

@destogl
Copy link
Member

destogl commented Jul 27, 2022

@moutalibbadr @hugo-tardiou can you add this functionality to Ignition plugin, please? We should you exactly the same concept (or at least something very similar) there too.

@ahcorde
Copy link
Collaborator

ahcorde commented Jul 27, 2022

should we backport this @destogl ?

@ahcorde ahcorde merged commit 6f76b76 into ros-controls:master Jul 27, 2022
@mcbed mcbed deleted the add_cm_namespace branch July 28, 2022 10:23
ahcorde pushed a commit that referenced this pull request Aug 15, 2022
destogl pushed a commit that referenced this pull request Aug 17, 2022
* Implemented perform_command_mode_switch override in GazeboSystem (#136)
* added namespace to controller manager (#147)
* Added logic for activating hardware interfaces (#139)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Keegan Sotebeer <ksotebeer95@gmail.com>
Co-authored-by: Maciej Bednarczyk <83034299+mcbed@users.noreply.github.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
ahcorde added a commit that referenced this pull request Nov 21, 2022
* fix maintainer email (#92)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* CHANGELOG

Signed-off-by: ahcorde <ahcorde@gmail.com>

* 0.0.4

* 0.0.5

* Update Foxy dockerfile (#101)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Declare dependency of gazebo_hardware_plugins to urdf in CMakeLists.txt (#117) (#119)

Co-authored-by: Martin Wudenka <Martin.Wudenka@gmx.de>

* Added diff drive example (#113)

Signed-off-by: ahcorde <ahcorde@gmail.com>

* changelog

Signed-off-by: ahcorde <ahcorde@gmail.com>

* 0.1.0

* [backport Foxy] #136 #147 #139 #134 (#150)

* Implemented perform_command_mode_switch override in GazeboSystem (#136)
* added namespace to controller manager (#147)
* Added logic for activating hardware interfaces (#139)

Signed-off-by: ahcorde <ahcorde@gmail.com>
Co-authored-by: Keegan Sotebeer <ksotebeer95@gmail.com>
Co-authored-by: Maciej Bednarczyk <83034299+mcbed@users.noreply.github.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>

* [Backport Foxy] Support for mimic joints and example with gripper. (#121)

* [Backport Foxy] Support for mimic joints and example with gripper.

* Enable loading params from multiple yaml files (#149) (#151)

Co-authored-by: Tony Najjar <tony.najjar@logivations.com>

* Adding simulation time parameter for the controller manager (#138) (#158)

Co-authored-by: Eslam Salah <eslamsalahelsheikh@gmail.com>

* Changelog

Signed-off-by: ahcorde <ahcorde@gmail.com>

* 0.1.1

* Add pre-commit hooks configuration (#161)

* Add pre-commit hooks configuration

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* Pre-commit in a separate action

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* Fix codespell

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Martin Wudenka <Martin.Wudenka@gmx.de>
Co-authored-by: Keegan Sotebeer <ksotebeer95@gmail.com>
Co-authored-by: Maciej Bednarczyk <83034299+mcbed@users.noreply.github.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar@logivations.com>
Co-authored-by: Eslam Salah <eslamsalahelsheikh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants