Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added position and velocity PID #25

Merged
merged 10 commits into from
Jul 27, 2020
Merged

Added position and velocity PID #25

merged 10 commits into from
Jul 27, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jun 29, 2020

This PR adds velocity and position PID

This PR is based on this other PR ros-controls/control_toolbox#97

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jun 29, 2020
@ahcorde ahcorde requested a review from chapulina June 29, 2020 11:47
@ahcorde ahcorde self-assigned this Jun 29, 2020
Copy link
Collaborator

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some instructions on how to test this? Thanks!

gazebo_ros2_control/package.xml Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina July 1, 2020 08:00
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 9, 2020

need a rebase of this PR #28 when is merge on master

@chapulina
Copy link
Collaborator

joint_trajectory_controller is failing to build on CI, with a different error from #30

 --- stderr: joint_trajectory_controller
/home/ros2_ws/src/ros2_controllers/joint_trajectory_controller/src/trajectory.cpp:22:10: fatal error: rcppmath/clamp.hpp: No such file or directory
   22 | #include "rcppmath/clamp.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 24, 2020

joint_trajectory_controller is failing to build on CI, with a different error from #30

 --- stderr: joint_trajectory_controller
/home/ros2_ws/src/ros2_controllers/joint_trajectory_controller/src/trajectory.cpp:22:10: fatal error: rcppmath/clamp.hpp: No such file or directory
   22 | #include "rcppmath/clamp.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.

This is fixed with the new release of Foxy

@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 27, 2020

friendly ping @chapulina

@chapulina chapulina merged commit 3f1332b into master Jul 27, 2020
@chapulina chapulina deleted the ahcorde/add_pid branch July 27, 2020 20:39
@ahcorde ahcorde mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants