-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update with ros2_control: return types (hardware_interface and controller_interface) #28
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have one question for my own education, the PR looks perfectly fine. I did the other side of these changes over at ros2_control and then ros2_controllers. Happy for this to be merged whenever you are ready
@@ -49,6 +49,7 @@ jobs: | |||
run: | | |||
cd /home/ros2_ws/ | |||
. /opt/ros/foxy/local_setup.sh | |||
export CMAKE_PREFIX_PATH=$AMENT_PREFIX_PATH:$CMAKE_PREFIX_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to do the same after struggling a lot with my dev environment and don't get why. Could you please enlighten me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was addressed in colcon-ros long time ago I think it's a missing dependency in one of the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been chasing this for a while now, it's why I didn't want to release control_toolbox as I couldn't locally build it without applying hacks... I think it comes from control_msgs but it beats me what's missing...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are <exec_depend>
https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/package.xml#L19-L22
You don't need these lines in the CMakeLists.txt https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/CMakeLists.txt#L5-L9
I will have a look to the rest of the packages, where are you facing this issue?
Return values have change in
hardware_interface
andcontroller_interface
Signed-off-by: ahcorde ahcorde@gmail.com