Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with ros2_control: return types (hardware_interface and controller_interface) #28

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 9, 2020

Return values have change in hardware_interface and controller_interface

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Jul 9, 2020
@ahcorde ahcorde requested a review from chapulina July 9, 2020 07:32
@ahcorde ahcorde self-assigned this Jul 9, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Jul 20, 2020

@chapulina friendly ping

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have one question for my own education, the PR looks perfectly fine. I did the other side of these changes over at ros2_control and then ros2_controllers. Happy for this to be merged whenever you are ready

@@ -49,6 +49,7 @@ jobs:
run: |
cd /home/ros2_ws/
. /opt/ros/foxy/local_setup.sh
export CMAKE_PREFIX_PATH=$AMENT_PREFIX_PATH:$CMAKE_PREFIX_PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do the same after struggling a lot with my dev environment and don't get why. Could you please enlighten me?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was addressed in colcon-ros long time ago I think it's a missing dependency in one of the packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been chasing this for a while now, it's why I didn't want to release control_toolbox as I couldn't locally build it without applying hacks... I think it comes from control_msgs but it beats me what's missing...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are <exec_depend> https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/package.xml#L19-L22

You don't need these lines in the CMakeLists.txt https://github.com/ros-controls/control_msgs/blob/foxy-devel/control_msgs/CMakeLists.txt#L5-L9

I will have a look to the rest of the packages, where are you facing this issue?

@ahcorde ahcorde merged commit f006156 into master Jul 21, 2020
@ahcorde ahcorde deleted the ahcorde/update/ros2_control branch July 21, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants