Load the URDF to the resource_manager before parsing it to CM #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikishor
force-pushed
the
fix_crash_for_missing_urdf_in_resource_manager
branch
from
bd8e5be
to
86ac698
Compare
|
@christophfroehlich |
bmagyar
approved these changes
Jan 17, 2024
|
CI is not passing because of the new API in |
|
@ahcorde Bence tagged and released the required changes in the distros |
|
With testing package CI is passing, merging it |
ahcorde
approved these changes
Jan 22, 2024
|
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Load the URDF to the resource_manager before parsing it to CM constructor (fixes ros-controls/ros2_control#1299) (cherry picked from commit f5baf71)
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Load the URDF to the resource_manager before parsing it to CM constructor (fixes ros-controls/ros2_control#1299) (cherry picked from commit f5baf71)
This was referenced Jan 22, 2024
ahcorde
added a commit
that referenced
this pull request
Jan 23, 2024
…267) * Load the URDF to the resource_manager before parsing it to CM constructor (fixes ros-controls/ros2_control#1299) (cherry picked from commit f5baf71) Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Jan 23, 2024
…266) * Load the URDF to the resource_manager before parsing it to CM constructor (fixes ros-controls/ros2_control#1299) (cherry picked from commit f5baf71) Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
HovorunB
added a commit
to pixel-robotics/gazebo_ros2_control
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed after the merging of ros-controls/ros2_control#1271 and ros-controls/ros2_control#1272. It seems like the gazebo_ros2_control doesn't load the URDF into the resource manager, and this is causing the CM services not to start.
However, loading the URDF with the
load_urdfmethod will probably fail, because this method originally loads and initializes the hardware interfaces and this step might probably fail. For this reason, I'm catching the exception here, but the overall behaviour will work.If approved, this will need backport to Iron and Humble
Needs: ros-controls/ros2_control#1301
Fixes: ros-controls/ros2_control#1299