Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the robot description parameter #277

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

annaborn
Copy link
Contributor

@annaborn annaborn commented Feb 2, 2024

This merge resolves the issue with robot description parameter in controller manager and controllers.
Some custom controllers require information about robot description, which are available normally over a parameter of controller manager and controllers in the ros2 control. However, this parameter was missing, if the controller manager (as well controllers) is started over gazebo ros2 control. Therefore, the custom controllers could not be used/tested with the gazebo.
I tested this code with my custom controllers.

If you have some remarks, I would be glad to introduce some improvement.

Here is an output of parameter list before (without robot description parameter):

/controller_manager:
  forward_position_controller.type
  joint_state_broadcaster.type
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  qos_overrides./parameter_events.publisher.depth
  qos_overrides./parameter_events.publisher.durability
  qos_overrides./parameter_events.publisher.history
  qos_overrides./parameter_events.publisher.reliability
  update_rate
  use_sim_time

/forward_position_controller:
  interface_name
  joints
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  update_rate
  use_sim_time

/joint_state_broadcaster:
  extra_joints
  interfaces
  joints
  map_interface_to_joint_state.effort
  map_interface_to_joint_state.position
  map_interface_to_joint_state.velocity
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  update_rate
  use_local_topics
  use_sim_time

And here is the output with the fix:

/controller_manager:
  forward_position_controller.type
  joint_state_broadcaster.type
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  qos_overrides./parameter_events.publisher.depth
  qos_overrides./parameter_events.publisher.durability
  qos_overrides./parameter_events.publisher.history
  qos_overrides./parameter_events.publisher.reliability
  robot_description
  update_rate
  use_sim_time

/forward_position_controller:
  interface_name
  joints
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  robot_description
  update_rate
  use_sim_time

/joint_state_broadcaster:
  extra_joints
  interfaces
  joints
  map_interface_to_joint_state.effort
  map_interface_to_joint_state.position
  map_interface_to_joint_state.velocity
  qos_overrides./clock.subscription.depth
  qos_overrides./clock.subscription.durability
  qos_overrides./clock.subscription.history
  qos_overrides./clock.subscription.reliability
  robot_description
  update_rate
  use_local_topics
  use_sim_time

To get the robot description parameter value over cli returns the correct urdf.

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annaborn annaborn requested a review from ahcorde February 5, 2024 10:59
@annaborn
Copy link
Contributor Author

annaborn commented Feb 5, 2024

check format https://github.com/ros-controls/gazebo_ros2_control/actions/runs/7762574839/job/21217428831?pr=277

@ahcorde
The trailing white space was removed and the curly brace placed on the same line with if condition.

@annaborn
Copy link
Contributor Author

annaborn commented Feb 12, 2024

@ahcorde @christophfroehlich
Hey guys!
What is the procedure to finish this PR? Do you need smth from my side?
The requested changes are done.

The PR was already verified last week: https://github.com/ros-controls/gazebo_ros2_control/actions/runs/7783361932

@ahcorde ahcorde merged commit 7f23568 into ros-controls:humble Feb 13, 2024
4 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Feb 13, 2024

https://github.com/Mergifyio backport iron master

Copy link
Contributor

mergify bot commented Feb 13, 2024

backport iron master

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 13, 2024
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
ahcorde pushed a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 7f23568)

Co-authored-by: AB <banonran@gmx.de>
ahcorde pushed a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 7f23568)

Co-authored-by: AB <banonran@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants