Updated RT goal handle to handle cancel requests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathias-luedtke
requested changes
Oct 28, 2017
There was a problem hiding this comment.
Code looks good, apart from the missing initiliazation.
We should enable CI tests ASAP (#20)
| @@ -55,6 +55,7 @@ class RealtimeServerGoalHandle | |||
| uint8_t state_; | |||
|
|
|||
| bool req_abort_; | |||
| bool req_cancel_; | |||
There was a problem hiding this comment.
needs to be initialized in constructor
|
This might help to fix some problems with canceling in |
nlamprian
force-pushed
the
kinetic-devel
branch
from
cd6947e
to
ef365bf
Compare
|
I'm not sure what is the best way to force travis to re-parse the CI configuration... Could you please rebase the PR on the latest |
mathias-luedtke
approved these changes
Oct 30, 2017
nlamprian
force-pushed
the
kinetic-devel
branch
from
ef365bf
to
cc6e4e0
Compare
|
Great, thank you! 👍 |
|
Should we cherry-pick this back into Indigo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the proposed changes, the real time goal handle allows for a cancel request to happen and the action to be terminated at a later time from within the real time thread.